Don't overwrite ChunkPrimer#setBlockState - compat for VSD#82
Merged
Conversation
Contributor
Author
|
As described here: #81 (comment) |
Contributor
|
@sk2048 Does the normal behavior still happen with this change? As for the release with these fixes, I need to finish up JEIDsI fixes included and appreciate if you could help out since you know your fixes better than I do lol |
Contributor
Author
|
Yes, without any other mods present ChunkPrimer#setBlockState becomes public void setBlockState(int x, int y, int z, IBlockState state) {
CallbackInfo ci = new CallbackInfo("setBlockState");
setIntBlockState(x, y, z, state, ci);
if (ci.isCancelled()) return;
// Normal vanilla code (dead)
}And setIntBlockState just private void setIntBlockState(int x, int y, int z, IBlockState state, CallbackInfo ci) {
intData[getBlockIndex(x, y, z)] = Block.BLOCK_STATE_IDS.get(state);
ci.cancel();
}It's ever so slightly more overhead, but far more resilient to other people making changes to it. |
Contributor
|
If it makes mods more compatible, I'm all for it. And we can talk on Discord about what needs fixing with the included fixes of JEIDsI and what still needs to be ported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81