Somewhat related to #50
Resetting the render state can actually be a fairly big issue when an item crashes during rendering because the vanilla BufferBuilder is extremely fragile and can keep crashing with "Already building" if its state is not cleared.
Here's a log that was reported to me where VanillaFix itself crashes while trying to show a crash report because the BufferBuilder is in a bad state:
(original crash at line 23553, VanillaFix crash at 24162)
https://paste.ee/p/ZNzfb
I used to catch and suppress these render errors in JEI, but unfortunately I have run into this and similar problems with other mod's rendering implementations (not just BufferBuilder). I didn't think it was worth trying to work around these issues any more because it was not reliable and I would be obscuring the original crash, so I just let the game crash normally on render errors now. You can get away with more hacking than I can in JEI so it is probably solvable.
Somewhat related to #50
Resetting the render state can actually be a fairly big issue when an item crashes during rendering because the vanilla
BufferBuilderis extremely fragile and can keep crashing with "Already building" if its state is not cleared.Here's a log that was reported to me where VanillaFix itself crashes while trying to show a crash report because the
BufferBuilderis in a bad state:(original crash at line 23553, VanillaFix crash at 24162)
https://paste.ee/p/ZNzfb
I used to catch and suppress these render errors in JEI, but unfortunately I have run into this and similar problems with other mod's rendering implementations (not just
BufferBuilder). I didn't think it was worth trying to work around these issues any more because it was not reliable and I would be obscuring the original crash, so I just let the game crash normally on render errors now. You can get away with more hacking than I can in JEI so it is probably solvable.