Skip to content

Conversation

@moehaje
Copy link
Contributor

@moehaje moehaje commented Jan 22, 2026

Summary

  • Introduces the workspace-home “multi-runs” flow with composer parity and instance tracking.
  • Adds model-generated run metadata and safer worktree naming/branching.
ScreenRecording.2026-01-22.at.20.07.25.mp4

Key changes

  • Workspace home view with project title + icon.png support and composer-first workflow.
  • Model selection dropdowns + multi-instance worktree runs.
  • Run cards + instance switching + status rendering; animated borders for running/reviewing/idle.
  • Backend/IPC support for metadata generation and worktree naming.
  • Composer integrations in workspace home (dictation, autocomplete, prompts/files).
  • Error handling per run with instance-level details.

Notes

  • Worktree home hides the run mode toggle (defaults to local behavior).
  • Branch/worktree naming normalized with prefixes + unique suffixing.
  • Metadata generation is best-effort (non-blocking for local runs).

Tests

  • pnpm lint
  • pnpm test
  • pnpm typecheck

moehaje and others added 16 commits January 22, 2026 15:07
Adds workspace home state/run tracking and multi-run logic (worktree/non-activating + per-run model override)
Adds the workspace home view, inline composer, and run list/instance cards
Hide expand button from workspace-home
Dictation text now inserts into the workspace-home prompt instead of the thread composer
Show per-run errors with instance detail and avoid global errors for partial runs.
Force worktree home to local runs and show only model selection.
@Dimillian
Copy link
Owner

Beautiful!

@Dimillian
Copy link
Owner

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c9e314bcc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian
Copy link
Owner

From my testing:

All good! I love it!
One issue: When creating a new agent, from the + button the workspace home quickly flash, can we fix that?

Some more feedback:

[High] Image‑only submissions (or worktree submits blocked by missing model selection) are silently dropped and attachments are cleared. WorkspaceHome allows send when activeImages exist, but startRun exits early if prompt is empty, and handleRunSubmit always clears attachments after onStartRun. This loses images without creating a run. src/features/workspaces/components/WorkspaceHome.tsx:252 and src/features/workspaces/hooks/useWorkspaceHome.ts:363

[Medium] Switching workspaces now always clears the active thread for that workspace (setActiveThreadId(null, workspaceId)), forcing the new workspace-home view even if a thread was previously selected. If the prior behavior was to persist the last active thread, this is a regression in navigation. src/features/workspaces/hooks/useWorkspaceSelection.ts:40

[Low] Missing coverage for the new workspace-home run flow and metadata generation. There are no tests exercising local/worktree run creation, error paths (no models, failed worktree), or attachment-only sends. Consider tests around src/features/workspaces/hooks/useWorkspaceHome.ts

^ I would love some tests, if you can ask your agents

Use provider model names and keep attachments unless a run starts.
Avoid clearing the active thread when selecting a workspace.
Add tests for partial failures, metadata title updates, and blocked worktree runs.
Drop unused setActiveThreadId wiring and stabilize localStorage test setup.
@moehaje
Copy link
Contributor Author

moehaje commented Jan 23, 2026

done, sir!

@Dimillian
Copy link
Owner

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit 55a606a into Dimillian:main Jan 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants