-
-
Notifications
You must be signed in to change notification settings - Fork 120
feat: workspace/worktree homes, multi-runs, metadata, and run orchestration polish #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workspace/worktree homes, multi-runs, metadata, and run orchestration polish #203
Conversation
Adds workspace home state/run tracking and multi-run logic (worktree/non-activating + per-run model override)
Adds the workspace home view, inline composer, and run list/instance cards
Hide expand button from workspace-home
Dictation text now inserts into the workspace-home prompt instead of the thread composer
…ing and status updates
Show per-run errors with instance detail and avoid global errors for partial runs.
Force worktree home to local runs and show only model selection.
|
Beautiful! |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c9e314bcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
From my testing: All good! I love it! Some more feedback: [High] Image‑only submissions (or worktree submits blocked by missing model selection) are silently dropped and attachments are cleared. WorkspaceHome allows send when activeImages exist, but startRun exits early if prompt is empty, and handleRunSubmit always clears attachments after onStartRun. This loses images without creating a run. src/features/workspaces/components/WorkspaceHome.tsx:252 and src/features/workspaces/hooks/useWorkspaceHome.ts:363 [Medium] Switching workspaces now always clears the active thread for that workspace (setActiveThreadId(null, workspaceId)), forcing the new workspace-home view even if a thread was previously selected. If the prior behavior was to persist the last active thread, this is a regression in navigation. src/features/workspaces/hooks/useWorkspaceSelection.ts:40 [Low] Missing coverage for the new workspace-home run flow and metadata generation. There are no tests exercising local/worktree run creation, error paths (no models, failed worktree), or attachment-only sends. Consider tests around src/features/workspaces/hooks/useWorkspaceHome.ts ^ I would love some tests, if you can ask your agents |
Use provider model names and keep attachments unless a run starts.
Avoid clearing the active thread when selecting a workspace.
Add tests for partial failures, metadata title updates, and blocked worktree runs.
Drop unused setActiveThreadId wiring and stabilize localStorage test setup.
|
done, sir! |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ScreenRecording.2026-01-22.at.20.07.25.mp4
Key changes
icon.pngsupport and composer-first workflow.Notes
Tests
pnpm lintpnpm testpnpm typecheck