Added support to scan for custom project/local path#15
Added support to scan for custom project/local path#15Dimillian merged 5 commits intoDimillian:mainfrom
Conversation
lRoMYl
force-pushed
the
feature/custom-projects
branch
from
5331948 to
b1773c1
Compare
|
@codex review |
|
This is really good, thanks! I'll merge and then make a few tweaks. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02c203f1f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Updated the skill grouping logic in SkillStore to consistently use filteredSkills instead of allSkillsForSlug. This ensures that platform selection, installed platforms, and delete IDs are limited to the filtered scope, improving accuracy in custom path sections.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 531c986a23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refactored skill grouping logic to ensure user directory (platform) skills are not hidden by custom path skills with the same slug. Updated SkillStore and SkillListView to use the new grouping method, and added tests to verify correct grouping behavior.
Enhanced the logic for determining the correct folder URL to open for a selected skill, adding more robust matching and a fallback path. This ensures the correct folder is opened even in edge cases where skill attributes or custom paths differ.
2 participants
Skills allows project based path as defined here alongside the global personal path.
This PR aims to provide the user flexibility to provide a custom path to discover/scan for skills for those project path instead of just showing the users global skills.
However, due to the nature of how project path only being accessible when initialised with the specific current working directory (cwd), the user experience should be designed differently from how global skills are managed / discovered.
My proposal:
Step 1
Step 2
Step 3
