Dark-mode legibility wave, advanced regex builder, release-pipeline repair (2026-07-24) #2
DingDingChae
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Dark-mode legibility wave, advanced regex builder, release-pipeline repair (2026-07-24)
What changed
Dark mode was systemically broken ("hardly visible text everywhere"):
StateColor::darkModeColorForwas applied twice on many paint paths and the mapping was not idempotent —MD3::Dark::onSurfacewas hex-identical to a light-theme key, so already-correct dark text was remapped to near-black (#2f3036on dark surfaces, pixel-verified from captures). Fixed by severing the hex aliases with imperceptible 1-step nudges plus invariant comments, along with: the unpainted white squares behind rounded bottom-bar controls (stale parent-background snapshots), the malformed green "capsule" (pill radius exceeding half-width), unreadable disabled button text, the Process-header switch/title overlap, orange category glyphs (modified-preset colour fallback leaking onto every glyph), dim field values, the grey caption band, and a stray floating icon overlapping the preset-row undo button.Advanced regex builder (user mandate): the search "tune" popover is now a full guided builder — literals with auto-escaping, character classes, anchors, groups/alternation, quantifiers (incl. lazy), a raw pattern editor with bidirectional sync, engine identification (std::regex / std::wregex, ECMAScript), live syntax feedback with friendly error mapping, a collapsible Test section with sample text, highlighted matches and capture groups, and copy-to-clipboard. Evaluation is bounded (2 000-char patterns, 20 000-char samples, 200 matches) and guarded against catastrophic backtracking. Wired into every search surface: Preferences, user presets, device farm, object-list sidebar (previously showed the builder but ignored it), preset-editor pill, Ctrl+F global search, device picker, and the two ImGui filters (font picker, assembly tree) via guarded
.*toggles. Docs:docs/features/windows/regex-builder.md."Latest release app not launching" root-caused and self-healed: the release binary was fine — fresh installs died at the OpenGL < 2.0 gate on GPU-less machines (VMs / Microsoft Basic Display Adapter). Releases now ship a hash-pinned Mesa llvmpipe 26.1.3 payload (
mesa\subfolder; archive + per-DLL SHA-256 verified in CI) and the app relaunches itself once onto software rendering when the gate trips, with a strict loop guard. Docs:docs/features/windows/software-gl-fallback.md.Release pipeline repaired:
on: push: {}also matched the tags the release job itself created, so every release re-triggered a build of the same commit and published another mis-titled release — an unbounded loop that piled up ~165 echo releases and scrambled the list order. Push triggers are branches-only now, the release job refuses tag refs, all echo runs were cancelled and echo releases deleted (tags preserved). Remaining: the newest good build, the badge "Latest", and the launch-verified portable preview.CI speed: per-ref cancel-in-progress (superseded wave builds stop early), and the Windows app build moved to Ninja + sccache (GitHub Actions cache backend) with
SLIC3R_MSVC_PDB=OFFon CI —/Zidefeats sccache and races the shared PDB under parallel cl (C1041), while/Z7pusheslibslic3r_gui.libover the 4 GiB.liblimit (LNK1248); CI ships no PDBs, so it now compiles without debug info. Local builds keep/Zi.Localization: 70 new Hong Kong Cantonese strings (451 total),
.morebuilt reproducibly (compile_translation.py --checkgreen).Verification evidence
BambuStudio.dllrelink verified against object timestamps..mo.f8461434e) was in progress at posting time — it also validates the new Ninja + sccache pipeline; the outcome will be recorded in HANDOFF.md when it lands. Earlier pipeline commits:0d4091229,6be213882,2486ebbf5Commits
e2ed70365— dark-mode legibility + advanced regex builder + softgl self-heal (38 files);f8461434e— stray undo-to-sys glyph fix + ROADMAPRemaining work
All reactions