Add options for optimization phases, and improve constant folding significantly#41
Merged
Conversation
…er to implement more
Dinnerbone
force-pushed
the
constant_folding
branch
from
0d987e2 to
37cff06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from everything, but it's a great step towards correctness.
Fun fact! The constant folding is different to runtime evaluation. That means if you did something like
trace(!"foo")it's totally different value tovar foo = "foo"; trace(!foo)Double fun fact! It looks like Ruffle got hit with that and we didn't realize. I think gnash tests might have too. Some of the tests we have just got compiled away, and give wrong values than what it should actually be. Hurray!