fix: check for visibility changes for damage#343
Conversation
|
Hmm... I feel like |
|
Let me quickly check if paint damage would do the trick. |
|
It seems like it at least needs |
|
I'll just merge this for now. Relayouting when |
|
Paint damage should be set automatically by Stylo. Looks like visibility doesn't have damage set (but that means it should default to "full damage" (rebuild_box)) https://github.com/servo/stylo/blob/main/style/properties/longhands/inherited_box.mako.rs#L8 |
|
Hmm... this still isn't quite right. Without incremental mode the box animates in and out, and the text is a clear bright white. With incremental mode + this PR there's no animation and the text is very faint. |
This fixes #335, by adding restyle damage on visibility changes.