Fix calendar e2e tests for month-end boundary#210
Open
p-jackson wants to merge 1 commit intoDioxusLabs:mainfrom
Open
Fix calendar e2e tests for month-end boundary#210p-jackson wants to merge 1 commit intoDioxusLabs:mainfrom
p-jackson wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
- Handle right arrow wrapping to next month when at last day - Use focusedDay instead of firstDay for back-navigation assertions
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-210/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calendar e2e tests are flaky depending on which day of they month they are run on. It already accounts for wrapping when pressing
ArrowDown, I've just done the same for clickingArrowRight.It would be more robust to select a known date before testing keyboard operations so we would know whether it would wrap or not. But the test also checks that today's date is the default focused date when you first tab into the control. Which is a good thing to check, so I've left as is.