feat: allow use of private key when connecting to sftp#6
Merged
sluipmoord merged 2 commits intomasterfrom Nov 29, 2024
Merged
Conversation
j4cuza
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
fileiopackage to enhance the SFTP connection functionality by adding support for private key authentication and includes corresponding tests.Enhancements to SFTP connection:
fileio/sftp-store.go: Added support for private key authentication by introducing thePrivateKeyPathfield and modifying theconnectmethod to handle both private key and password authentication methods.Testing the new functionality:
fileio/sftp-store_test.go: Added tests to verify the SFTP connection using both private key and password authentication methods. The tests ensure that the connection is successful and that the file listing is not empty.