Conversation
|
I am not an everyday Java developer so I asked Copilot to help. @ericmmears can you comment on the following question I asked Copilot? It feels like some of these new files have nothing to do with support for RSA-OAEP? You are correct. Based on the files added in this PR, several new files under src/main/java/org/nhindirect/common/rest/ (such as AbstractBasicAuthServiceSecurityManager.java, AbstractGetRequest.java, AbstractSecuredService.java, AbstractUnsecuredService.java, BootstrapBasicAuthServiceSecurityManager.java, HttpClientFactory.java, SecuredServiceRequestBase.java, etc.) seem to be related to HTTP service abstraction, client management, and authentication—not directly to RSA-OAEP cryptographic support. The RSA-OAEP related changes appear to be focused in files such as OptionsManager.java and OptionsParameter.java, which add new options and parameters for cryptographic algorithms. In contrast, the large group of new "rest" package files seem to introduce a reusable HTTP client/service infrastructure, which is a broader architectural enhancement and not specific to RSA-OAEP. If you want a precise breakdown of which files are directly tied to RSA-OAEP support and which are not, I can provide further detail. Would you like a categorized list or an analysis of a particular file or set of files? |
|
Hi Joe, Eric |
These were initially added to attempt to support agent and direct-common in older major release versions of the RI, but it has been determined that this compatibility model will not be supported.
|
This PR addresses issue #13. |
gm2552
left a comment
There was a problem hiding this comment.
Removed REST constructs as these will not be back ported for 8.x.
|
@JoeShook To answer the question, I have made an executive call that we are not going to support the model of making all components 100% backward compatible with previous major releases. As much as I would like this to be the case (and I tried to do it as much as possible in earlier versions of the Direct Java RI), it just isn't practical to keep up with the ever changing technical landscape. So for the OASP feature update, direct-common and agent 8.x will only technically be supported for the 8.x release train of the Java RI. Supported for older versions of the RI require back porting using source code from an appropriate tag. |
updated direct-common for RSA-OAEP