Skip to content

Rsa oaep develop#12

Merged
gm2552 merged 3 commits intodevelopfrom
RSA-OAEP-develop
Jun 25, 2025
Merged

Rsa oaep develop#12
gm2552 merged 3 commits intodevelopfrom
RSA-OAEP-develop

Conversation

@ericmmears
Copy link
Copy Markdown

updated direct-common for RSA-OAEP

@JoeShook
Copy link
Copy Markdown

I am not an everyday Java developer so I asked Copilot to help. @ericmmears can you comment on the following question I asked Copilot?

It feels like some of these new files have nothing to do with support for RSA-OAEP?

You are correct. Based on the files added in this PR, several new files under src/main/java/org/nhindirect/common/rest/ (such as AbstractBasicAuthServiceSecurityManager.java, AbstractGetRequest.java, AbstractSecuredService.java, AbstractUnsecuredService.java, BootstrapBasicAuthServiceSecurityManager.java, HttpClientFactory.java, SecuredServiceRequestBase.java, etc.) seem to be related to HTTP service abstraction, client management, and authentication—not directly to RSA-OAEP cryptographic support.

The RSA-OAEP related changes appear to be focused in files such as OptionsManager.java and OptionsParameter.java, which add new options and parameters for cryptographic algorithms. In contrast, the large group of new "rest" package files seem to introduce a reusable HTTP client/service infrastructure, which is a broader architectural enhancement and not specific to RSA-OAEP.

If you want a precise breakdown of which files are directly tied to RSA-OAEP support and which are not, I can provide further detail. Would you like a categorized list or an analysis of a particular file or set of files?

@ericmmears
Copy link
Copy Markdown
Author

Hi Joe,
You are absolutely correct. These were added so the Agent could be used for earlier versions of the Java RI. Earlier agents had these rest code files, and they had been taken out in later versions of the Agent. I'm open to removing them if we get more feedback.

Eric

These were initially added to attempt to support agent and direct-common
in older major release versions of the RI, but it has been determined
that this compatibility model will not be supported.
@gm2552
Copy link
Copy Markdown
Contributor

gm2552 commented Jun 25, 2025

This PR addresses issue #13.

@gm2552 gm2552 added the enhancement New feature or request label Jun 25, 2025
Copy link
Copy Markdown
Contributor

@gm2552 gm2552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed REST constructs as these will not be back ported for 8.x.

@gm2552
Copy link
Copy Markdown
Contributor

gm2552 commented Jun 25, 2025

@JoeShook To answer the question, I have made an executive call that we are not going to support the model of making all components 100% backward compatible with previous major releases. As much as I would like this to be the case (and I tried to do it as much as possible in earlier versions of the Direct Java RI), it just isn't practical to keep up with the ever changing technical landscape.

So for the OASP feature update, direct-common and agent 8.x will only technically be supported for the 8.x release train of the Java RI. Supported for older versions of the RI require back porting using source code from an appropriate tag.

@gm2552 gm2552 merged commit 0168f1e into develop Jun 25, 2025
@gm2552 gm2552 deleted the RSA-OAEP-develop branch June 25, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants