fix(cli): default missing props to {} in split-concerns output (#84)#85
Merged
Conversation
splitComponentByConcern and extractApiFromSubcomponents were filling
missing props with [] instead of {}, violating the schema where Props
is an object. Corrects ComponentApiData/SubcomponentApiData typings to
Record<string, any> and adds regression tests.
Closes #84
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splitComponentByConcernandextractApiFromSubcomponentswere filling missingpropswith[]instead of{}, producing output that violated the schema (Propsis an object). Components with no Figma properties (e.g.egdsDivider,egdsSearchBarExperimental) now emitprops: {}.ComponentApiData/SubcomponentApiDatato typepropsasRecord<string, any>.Test plan
npm testinpackages/cli— 176 passed (3 new)npm run buildsucceeds--split-concernsrun on a propless componentCloses #84
🤖 Generated with Claude Code