Harden WebSocket reconnection logic in Unity plugin#22
Merged
Conversation
Three defensive fixes to prevent stale state from blocking reconnection: - Add _connecting guard to prevent overlapping ConnectAsync calls - Check socket identity before clobbering _isConnected in catch/finally blocks, so a stale receive loop or failed attempt can't reset state that a newer successful connection already set - Add 10s timeout on ConnectAsync so hanging TCP connections don't block reconnection indefinitely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defensive fixes to the Unity plugin's WebSocket reconnection logic to prevent stale state from blocking reconnection:
_connectingflag so overlappingConnectAsynccalls are skipped rather than racing each otherConnectAsynccatch block andReceiveLoopAsyncfinally block now verify_webSocket == ownSocketbefore clearing_isConnected, preventing a stale/cancelled attempt from clobbering a newer successful connectionConnectAsyncvia linkedCancellationTokenSourceso hanging TCP connections can't block reconnection indefinitelyTest plan