fix(core): prevent finished models from stalling the environment clock#131
Merged
profsergiocosta merged 1 commit intodevelopfrom May 3, 2026
Merged
fix(core): prevent finished models from stalling the environment clock#131profsergiocosta merged 1 commit intodevelopfrom
profsergiocosta merged 1 commit intodevelopfrom
Conversation
A model whose end_time had passed was still included in the pending event queue, causing the clock to stall at its next_time indefinitely. Fix: filter pending events by both env.end_time and model.end_time. Add test suite for Environment/Model scheduler (27 tests covering clock accuracy, model boundaries, heterogeneous steps, lifecycle hooks, re-run semantics, and edge cases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model whose end_time had passed was still included in the pending event queue, causing the clock to stall at its next_time indefinitely.
Fix: filter pending events by both env.end_time and model.end_time.
Add test suite for Environment/Model scheduler (27 tests covering clock accuracy, model boundaries, heterogeneous steps, lifecycle hooks, re-run semantics, and edge cases)