ENG-1905 Add shared content type constants#1174
Merged
Merged
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@codex review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@repo/content-modelcontent type constants into the cross-app content contract.contentTypes.markdown.@repo/databaseandroam.Notes
text/plainusage was left alone because it is not the DG content representation discriminator.ENG-1906is still separate assigned database migration work; this PR does not duplicate that branch.Validation
pnpm --filter @repo/content-model testpnpm exec prettier --check packages/database/src/crossAppNodeContract.ts packages/database/src/crossAppNodeContract.example.ts apps/roam/src/utils/convertRoamNodeToFullContent.example.ts packages/database/package.json apps/roam/package.json pnpm-lock.yamlpnpm --filter @repo/database check-typespnpm --filter roam check-typespnpm --filter @repo/database lint(warnings only, pre-existing)pnpm --filter roam lint(warnings only, pre-existing)git diff --checkLinear: https://linear.app/discourse-graphs/issue/ENG-1905/add-shared-content-type-constants