Skip to content

two migration errors #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

two migration errors #224

merged 1 commit into from
Jun 19, 2025

Conversation

@maparent
Copy link
Collaborator

@maparent maparent commented Jun 19, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jun 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discourse-graph ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 2:22am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@maparent
Copy link
Collaborator Author

maparent commented Jun 19, 2025

This is about getting the db diff to say the schema is exactly the same as running the migrations. Did the rename too fast.

@maparent maparent requested a review from mdroidian June 19, 2025 02:23
@maparent
Copy link
Collaborator Author

maparent commented Jun 19, 2025

(not urgent)

mdroidian
mdroidian reviewed Jun 19, 2025
View reviewed changes
packages/database/supabase/migrations/20250619021503_correct_migrations.sql

alter function "public".local_concept_to_db_concept(data concept_local_input) rename to _local_concept_to_db_concept;

CREATE OR REPLACE FUNCTION public.upsert_concepts(v_space_id bigint, data jsonb)
Copy link
Contributor

@mdroidian mdroidian Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error is this fixing? Could you link the the source of the error?

Copy link
Collaborator Author

@maparent maparent Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because I renamed the function to indicate it's private in the schema but forgot to do so in the migration. So in this migration I rename the private function, and I have to re-define the function that uses it to use the new name. It is the only change to that function. Here I'm clearly migrating to align to the schema as source of truth.

Copy link
Contributor

@mdroidian mdroidian Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/DiscourseGraphs/discourse-graph/pull/215/files#diff-22bac1fb1de78f55daaeedaaa408e1bd563554544a152bf0c82630d8675a69daR139

@mdroidian mdroidian self-requested a review June 19, 2025 18:41
@maparent maparent merged commit a0a6082 into main Jun 19, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this to Done in General Jun 19, 2025
@maparent maparent deleted the migration_corrections branch June 19, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdroidian mdroidian mdroidian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
General
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maparent @mdroidian