Skip to content

Conversation

@maparent
Copy link
Collaborator

@maparent maparent commented Jun 26, 2025

We have an issue with turbo lint not working well, not linting all subprojects, and not using our eslint settings.
This PR is mostly a modernization of our eslint configuration, with new flat configs.
I have also updated prettier, and made sure all packages were using the same version of typescript.
Then, this did not work as well in vscode, so I had to be more more explicit about subprojects.
It was subsequently aligned with a fresh turbo repo (from npx create-turbo@latest) and the differences were minimized, while still maintaining a functional turbo build / dev / lint.

Summary by CodeRabbit

  • New Features

    • Introduced new ESLint and TypeScript lint configuration files for improved code linting consistency across multiple projects.
    • Added a multi-root workspace configuration for easier project management.
  • Chores

    • Migrated ESLint configurations to the new flat config format and updated related settings.
    • Updated and streamlined TypeScript configuration files for better project structure and exclusion of build directories.
    • Revised and upgraded various development dependencies for ESLint, Prettier, and TypeScript.
    • Updated lint scripts and relaxed lint warning limits in some packages.
    • Removed deprecated or redundant configuration files.

@linear
Copy link

linear bot commented Jun 26, 2025

@supabase
Copy link

supabase bot commented Jun 26, 2025

This pull request has been ignored for the connected project plzkmulvmuhdpcmnyrhm because there are no changes detected in projects/database/supabase/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@maparent maparent force-pushed the ENG-521-eslint-flat-config branch from 6eb3a2e to d990d4d Compare June 26, 2025 02:54
@maparent maparent force-pushed the ENG-521-eslint-flat-config branch 4 times, most recently from 76aafa8 to e7f1471 Compare July 1, 2025 01:02
@maparent maparent requested a review from mdroidian July 1, 2025 01:07
@maparent maparent force-pushed the ENG-521-eslint-flat-config branch 5 times, most recently from cf46de8 to bbb4a41 Compare July 10, 2025 18:23
@maparent maparent force-pushed the ENG-521-eslint-flat-config branch from bbb4a41 to 0384559 Compare July 14, 2025 02:38
"compilerOptions": {
"baseUrl": ".",
"outDir": "dist",
"target": "ESNext",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am nervous about removing these settings as they were inherited from the original Query Builder and have sweeping ramifications to compile, build, and dev.

I ran a few local and manual tests, so far everything seems to check out, so I won't block on this.

@maparent maparent force-pushed the ENG-521-eslint-flat-config branch from 0384559 to baa2946 Compare July 14, 2025 14:51
@mdroidian mdroidian merged commit 9b0d889 into main Jul 19, 2025
3 of 4 checks passed
@mdroidian mdroidian deleted the ENG-521-eslint-flat-config branch July 19, 2025 22:54
@github-project-automation github-project-automation bot moved this to Done in General Jul 19, 2025
@mdroidian
Copy link
Contributor

mdroidian commented Jul 20, 2025

@maparent it looks like apps/roam/package-lock.json was moved to apps/website/package-lock.json somehow in this PR.

EDIT: reverted in #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants