-
Notifications
You must be signed in to change notification settings - Fork 3
Eng-521 repair and modernize eslint with flat config #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
6eb3a2e to
d990d4d
Compare
76aafa8 to
e7f1471
Compare
cf46de8 to
bbb4a41
Compare
bbb4a41 to
0384559
Compare
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "dist", | ||
| "target": "ESNext", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am nervous about removing these settings as they were inherited from the original Query Builder and have sweeping ramifications to compile, build, and dev.
I ran a few local and manual tests, so far everything seems to check out, so I won't block on this.
0384559 to
baa2946
Compare
We have an issue with turbo lint not working well, not linting all subprojects, and not using our eslint settings.
This PR is mostly a modernization of our eslint configuration, with new flat configs.
I have also updated prettier, and made sure all packages were using the same version of typescript.
Then, this did not work as well in vscode, so I had to be more more explicit about subprojects.
It was subsequently aligned with a fresh turbo repo (from
npx create-turbo@latest) and the differences were minimized, while still maintaining a functional turbo build / dev / lint.Summary by CodeRabbit
New Features
Chores