ENG-583-add-target-type-column #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates to Preview Branch (ENG-583-add-entity-type-to-sync) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
maparent
force-pushed
the
ENG-583-add-entity-type-to-sync
branch
from
49e11e3 to
583d3cb
Compare
mdroidian
approved these changes
Jul 14, 2025
Contributor
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Let's try to make sure the title/branch name are for the same linear task id.
This is now linking/automating the status' of both task.
If you want to reference a related task that is not the primary task, you can add a link to the body comment and it won't trigger the linear app.
maparent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in eng-583:
The sync_info table was designed so the target could be a member of any table, i.e. not an explicit foreign key. This is an implementation of my favoured path, adding an EntityType column so we can ensure proper logic.
Having this allows me to add RLS to that table.