ENG-779 - Refactor Tldraw component to improve canvas rendering logic #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdroidian
commented
Aug 25, 2025
mdroidian
commented
- Simplified the rendering logic by consolidating checks for the root element and child elements.
- Updated the attribute handling for TLDRAW_DATA_ATTRIBUTE to ensure proper visibility toggling of Roam blocks.
- Enhanced the styling rules in tldrawStyles to maintain consistency in block visibility when the canvas is present.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
mdroidian
commented
Aug 25, 2025
Contributor
Author
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
@CodeRabbit full review
- Simplified the rendering logic by consolidating checks for the root element and child elements. - Updated the attribute handling for TLDRAW_DATA_ATTRIBUTE to ensure proper visibility toggling of Roam blocks. - Enhanced the styling rules in tldrawStyles to maintain consistency in block visibility when the canvas is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.