ENG-804 Load Settings Bug #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Collaborator
Author
|
It looked like an artifact of previous changes. The inherited value is jsx-roam, and that is from the turbo configuration, so I thought I would go with the official value, and the side-effect was not immediately obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-804/load-settings-bug
Restoring the previous jsx setting fixes the bug.
Not sure about the semantics of that flag, interesting that it's different in roam vs all other react projects.
I also found out that the issue centres on the loop at Settings.tsx:194-201. Removing those lines also allows the panel to appear the first time. Replacing the content of the loop with something trivial does not help.