Skip to content

Set node summoning menu default trigger to @ #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Set node summoning menu default trigger to @ #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6301fb
Fix: Default node search trigger to '@'
cursoragent Sep 16, 2025
fae3bf0
Refactor: Replace direct API calls with getSetting for node search tr…
mdroidian Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/roam/src/components/DiscourseNodeSearchMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import getDiscourseNodes, { DiscourseNode } from "~/utils/getDiscourseNodes";
import getDiscourseNodeFormatExpression from "~/utils/getDiscourseNodeFormatExpression";
import { escapeCljString } from "~/utils/formatUtils";
import { Result } from "~/utils/types";
import { getSetting } from "~/utils/extensionSettings";

type Props = {
textarea: HTMLTextAreaElement;
Expand Down Expand Up @@ -536,7 +537,7 @@ export const NodeSearchMenuTriggerSetting = ({
}) => {
const extensionAPI = onloadArgs.extensionAPI;
const [nodeSearchTrigger, setNodeSearchTrigger] = useState<string>(
extensionAPI.settings.get("node-search-trigger") as string,
getSetting("node-search-trigger", "@"),
);

const handleNodeSearchTriggerChange = (
Expand Down
5 changes: 2 additions & 3 deletions apps/roam/src/utils/initializeObserversAndListeners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import {
} from "~/utils/renderTextSelectionPopup";
import { renderNodeTagPopupButton } from "./renderNodeTagPopup";
import { formatHexColor } from "~/components/settings/DiscourseNodeCanvasSettings";
import { getSetting } from "./extensionSettings";

const debounce = (fn: () => void, delay = 250) => {
let timeout: number;
Expand Down Expand Up @@ -230,9 +231,7 @@ export const initObservers = async ({
}
};

const customTrigger = onloadArgs.extensionAPI.settings.get(
"node-search-trigger",
) as string;
const customTrigger = getSetting("node-search-trigger", "@");

const discourseNodeSearchTriggerListener = (e: Event) => {
const evt = e as KeyboardEvent;
Expand Down