Set node summoning menu default trigger to @

[mdroidian]

Set the node summoning menu default trigger to '@' to improve discoverability and align with existing default setting patterns.

---

Linear Issue: ENG-459

Summary by CodeRabbit

• Bug Fixes

  • Ensures the node search trigger reliably defaults to “@” when no user setting is defined, preventing missing-trigger issues.

• Refactor

  • Centralized retrieval of the node search trigger setting to improve consistency and maintainability across the app.

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[linear]

ENG-459 Set node summoning menu default trigger to @

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[mdroidian]

@CodeRabbit full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

Centralizes retrieval of the "node-search-trigger" setting by importing and using getSetting with a default "@" in DiscourseNodeSearchMenu.tsx and initializeObserversAndListeners.ts. Replaces direct extensionAPI.settings.get calls. No exported signatures changed; existing onChange and listener control flow remain intact.

Changes

Cohort / File(s)	Summary
Centralized node-search-trigger setting apps/roam/src/components/DiscourseNodeSearchMenu.tsx, apps/roam/src/utils/initializeObserversAndListeners.ts	Replace direct extensionAPI.settings.get("node-search-trigger") with getSetting("node-search-trigger", "@"); add imports for the helper; preserve existing control flow and update logic; introduce default value "@" when unset.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant L as Key Listener
  participant S as getSetting
  participant A as extensionAPI.settings
  participant M as DiscourseNodeSearchMenu

  U->>L: Type character
  L->>S: getSetting("node-search-trigger", "@")
  S->>A: settings.get("node-search-trigger")
  A-->>S: value | undefined
  note right of S: Returns stored value or default "@"
  S-->>L: trigger
  alt trigger matches typed char
    L->>M: Open node search menu
  else
    L-->>U: Ignore
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [ENG-235] Create DG summoning menu #169: Adjusts node-search-trigger handling in the same files; closely aligned with centralizing retrieval via getSetting.
• [ENG-204] Move from localStorage to extensionAPI.settings #133: Introduces the centralized getSetting helper that this PR adopts for settings access.
• [ENG-259] Create Observer and UI pattern #138: Modifies the Discourse node search UI and listener logic that consume the node-search-trigger setting.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Set node summoning menu default trigger to @" succinctly and accurately summarizes the central change in this PR—switching the node-search trigger default to "@" as implemented in DiscourseNodeSearchMenu.tsx and initializeObserversAndListeners.tsx—so it is specific, concise, and meaningful for a teammate scanning history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/roam/src/utils/initializeObserversAndListeners.ts (1)

234-234: Trigger value is snapshotted at init; won’t reflect runtime setting changes.

If users change the trigger in settings, discourseNodeSearchTriggerListener will still use the old value until re-init. Fetch per event or subscribe to setting changes.

Apply this minimal change to read the latest value on each key event:

-  const customTrigger = getSetting("node-search-trigger", "@");
+  // Read the latest trigger on each key event to honor runtime changes

And inside discourseNodeSearchTriggerListener:

-  const discourseNodeSearchTriggerListener = (e: Event) => {
+  const discourseNodeSearchTriggerListener = (e: Event) => {
+    const customTrigger = getSetting("node-search-trigger", "@");

Alternatively, cache and update via a settings onChange hook if available.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b715b4 and fae3bf0.

📒 Files selected for processing (2)

• apps/roam/src/components/DiscourseNodeSearchMenu.tsx (2 hunks)
• apps/roam/src/utils/initializeObserversAndListeners.ts (2 hunks)

🔇 Additional comments (3)

apps/roam/src/components/DiscourseNodeSearchMenu.tsx (2)

28-28: Centralized setting retrieval looks good.

Importing getSetting aligns this component with the new default behavior and reduces duplication.

---

540-541: Default trigger initialization is correct; confirm helper semantics.

Assuming getSetting is synchronous and returns "" when explicitly set empty (vs. undefined), this is fine. If it’s async or needs extensionAPI context, wire that in or memoize via onloadArgs.

apps/roam/src/utils/initializeObserversAndListeners.ts (1)

48-48: LGTM on consolidating settings access.

Using getSetting here keeps the default consistent across the app.