Skip to content

ENG-947 dragging and/or clicking on section header crashes the sidebar #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2025
Merged

ENG-947 dragging and/or clicking on section header crashes the sidebar #481

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3439b0c
remove open target call for personal section header
sid597 Oct 8, 2025
ee3703b
fix useconfig hook, fix overflow-scroll bug in left sidebar view
sid597 Oct 19, 2025
54d3e6e
fix overflow-scroll bug in left sidebar view
sid597 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions apps/roam/src/components/LeftSidebarView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,9 @@ const PersonalSectionItem = ({
<div className="flex w-full items-center justify-between">
<div
className="flex items-center"
onClick={(e: React.MouseEvent) => {
onClick={() => {
if ((section.children?.length || 0) > 0) {
handleChevronClick();
} else {
void openTarget(e, section.text);
}
}}
>
Expand Down Expand Up @@ -452,7 +450,7 @@ export const useConfig = () => {
unsubscribe();
};
}, []);
return config;
return { config, setConfig };
};

export const refreshAndNotify = () => {
Expand Down Expand Up @@ -572,8 +570,8 @@ const FavouritesPopover = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {
};

const LeftSidebarView = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {
const initialConfig = useConfig();
const [config, setConfig] = useState(initialConfig);
const { config, setConfig } = useConfig();

return (
<>
<FavouritesPopover onloadArgs={onloadArgs} />
Expand All @@ -599,11 +597,11 @@ export const mountLeftSidebar = (
}
root = document.createElement("div");
root.id = id;
root.className = "starred-pages overflow-scroll";
root.className = "starred-pages";
root.onmousedown = (e) => e.stopPropagation();
wrapper.appendChild(root);
} else {
root.className = "starred-pages overflow-scroll";
root.className = "starred-pages";
}
ReactDOM.render(<LeftSidebarView onloadArgs={onloadArgs} />, root);
};
Expand Down