-
Notifications
You must be signed in to change notification settings - Fork 4
ENG-954 Re-add focus removal after node tag creation #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-954 Re-add focus removal after node tag creation #492
Conversation
Co-authored-by: mclicks <mclicks@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
…seNodeMenu Co-authored-by: mclicks <mclicks@gmail.com>
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughA document body click is added to the tag insertion logic in DiscourseNodeMenu.tsx to remove focus from the block immediately after tag creation via the Node Menu, ensuring CSS styling is applied without delay. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRsPre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-25T15:53:21.799ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Re-add
document.body.click()to remove focus after node tag creation in Roam.This restores the expected UI behavior where the app exits block editing mode after a node tag (candidate node) is created, addressing a regression introduced by the removal of
document.clickin ENG-931.Linear Issue: ENG-954
Summary by CodeRabbit