Skip to content

ENG-969 Add open node in sidebar button to canvas nodes #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

ENG-969 Add open node in sidebar button to canvas nodes #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 61 additions & 8 deletions apps/roam/src/components/DiscourseContextOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,49 @@ const getOverlayInfo = async (tag: string): Promise<DiscourseData> => {
}
};

type DiscourseContextOverlayProps =
| { id: string; tag: string; uid?: never }
| { id: string; uid: string; tag?: never }
| { id: string; tag: string; uid: string };
const OPACITY_VALUES = [
"5",
"10",
"15",
"20",
"25",
"30",
"35",
"40",
"45",
"50",
"55",
"60",
"65",
"70",
"75",
"80",
"85",
"90",
"95",
"100",
] as const;

type OpacityValue = (typeof OPACITY_VALUES)[number];

type DiscourseContextOverlayBaseProps = {
id: string;
iconColor?: string;
textColor?: string;
opacity?: OpacityValue;
};

// need tag or uid
type DiscourseContextOverlayProps = DiscourseContextOverlayBaseProps &
({ tag: string; uid?: never } | { tag?: never; uid: string });

const DiscourseContextOverlay = ({
tag,
id,
uid,
iconColor,
textColor,
opacity = "100",
}: DiscourseContextOverlayProps) => {
const tagUid = useMemo(() => uid ?? getPageUidByPageTitle(tag), [uid, tag]);
const [loading, setLoading] = useState(true);
Expand Down Expand Up @@ -131,10 +166,28 @@ const DiscourseContextOverlay = ({
disabled={loading}
>
<div className="flex items-center gap-1.5">
<Icon icon={"diagram-tree"} />
<span className="mr-1 leading-none">{loading ? "-" : score}</span>
<Icon icon={"link"} />
<span className="leading-none">{loading ? "-" : refs}</span>
<Icon
icon={"diagram-tree"}
color={iconColor}
style={{ opacity: `${Number(opacity) / 100}` }}
/>
<span
className={`mr-1 leading-none opacity-${opacity}`}
style={{ color: textColor }}
>
{loading ? "-" : score}
</span>
<Icon
icon={"link"}
color={iconColor}
style={{ opacity: `${Number(opacity) / 100}` }}
/>
<span
className={`leading-none opacity-${opacity}`}
style={{ color: textColor }}
>
{loading ? "-" : refs}
</span>
</div>
</Button>
}
Expand Down
27 changes: 26 additions & 1 deletion apps/roam/src/components/canvas/DiscourseNodeUtil.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import { useExtensionAPI } from "roamjs-components/components/ExtensionApiContex
import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTitle";
import isLiveBlock from "roamjs-components/queries/isLiveBlock";
import updateBlock from "roamjs-components/writes/updateBlock";
import openBlockInSidebar from "roamjs-components/writes/openBlockInSidebar";
import { Button, Icon } from "@blueprintjs/core";
import createDiscourseNode from "~/utils/createDiscourseNode";
import { DiscourseNode } from "~/utils/getDiscourseNodes";
import { isPageUid } from "./Tldraw";
Expand Down Expand Up @@ -517,6 +519,26 @@ export class BaseDiscourseNodeUtil extends ShapeUtil<DiscourseNodeShape> {
onPointerEnter={() => setOverlayMounted(true)}
>
<div style={{ pointerEvents: "all" }}>
{/* Open in Sidebar Button */}
<Button
className="absolute left-1 top-1 z-10"
minimal
small
icon={
<Icon
icon="panel-stats"
color={textColor}
className="opacity-50"
/>
}
onClick={(e) => {
e.stopPropagation();
void openBlockInSidebar(shape.props.uid);
}}
onPointerDown={(e) => e.stopPropagation()}
title="Open in sidebar (Shift+Click)"
/>

{shape.props.imageUrl && isKeyImage ? (
<img
src={shape.props.imageUrl}
Expand All @@ -537,12 +559,15 @@ export class BaseDiscourseNodeUtil extends ShapeUtil<DiscourseNodeShape> {
>
{overlayMounted && isOverlayEnabled && (
<div
className="roamjs-discourse-context-overlay-container absolute right-0 top-0"
className="roamjs-discourse-context-overlay-container absolute right-1 top-1"
onPointerDown={(e) => e.stopPropagation()}
>
<DiscourseContextOverlay
uid={shape.props.uid}
id={`${shape.id}-overlay`}
opacity="50"
textColor={textColor}
iconColor={textColor}
/>
</div>
)}
Expand Down