ENG-984 Add DiscourseContextOverlay support in ResultsTable

[mdroidian]

simple v0 with the popup but this is the only way to async query the discourse relations/references to get the values.
action:discourse:overlay

Summary by CodeRabbit

• New Features
  • Introduced an "overlay" suggestion option for discourse-related actions, allowing users to view and interact with context overlays alongside other interaction options.

[linear]

ENG-984 add v0 discourse context to query builder selection

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[mdroidian]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

Added DiscourseContextOverlay rendering logic to ResultsTable component with conditional action-aware rendering. When action type is "discourse" and displayed value matches a new constant, renders DiscourseContextOverlay instead of standard Button. Introduced new CONTEXT_OVERLAY_SUGGESTION constant in predefinedSelections.ts. Updated UID handling to consistently propagate actionUid throughout event payloads.

Changes

Cohort / File(s)	Summary
New Constant Definition apps/roam/src/utils/predefinedSelections.ts	Added new exported constant CONTEXT_OVERLAY_SUGGESTION with value "overlay" to enable discourse-related overlay suggestions.
Action-Aware Rendering apps/roam/src/components/results-view/ResultsTable.tsx	Added imports for DiscourseContextOverlay, nanoid, and CONTEXT_OVERLAY_SUGGESTION. Implemented conditional rendering logic that detects when action type is "discourse" and displayed value matches CONTEXT_OVERLAY_SUGGESTION, then renders DiscourseContextOverlay component with generated ID and UID. Updated UID handling from type-cast to direct fallback and replaced uid: r[${key}-uid] with uid: actionUid in event payloads for consistent UID propagation.

Sequence Diagram

sequenceDiagram
    participant ResultRow as ResultRow Cell
    participant Logic as Action Logic
    participant Button as Button Component
    participant Overlay as DiscourseContextOverlay
    participant Event as Event Payload

    ResultRow->>Logic: Compute action with uid
    alt action === "discourse" AND value === CONTEXT_OVERLAY_SUGGESTION
        Logic->>Overlay: Render with uid, id: nanoid()
        Overlay->>Event: Dispatch with actionUid
    else
        Logic->>Button: Render standard button
        Button->>Event: Dispatch with actionUid
    end
    Event->>Event: Propagate consistent UID

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The changes introduce conditional rendering logic with a new component integration in an existing results table component, requiring verification of the action type detection, component prop passing, UID consistency, and event payload handling. The constant definition is trivial, but the overall scope spans logic density and file interactions of moderate complexity.

Possibly related PRs

• ENG-969 Add open node in sidebar button to canvas nodes #495: Modifies DiscourseContextOverlay's prop types and styling; directly affects how the newly rendered overlay component in ResultsTable will function.
• Roam: Discourse Context Overlay - remove queue and arbitrary delay #127: Changes DiscourseContextOverlay's API by removing the id parameter; impacts the component instantiation in ResultsTable that now passes generated IDs via nanoid.
• ENG-788 - Add Discourse Context Overlay to tldraw canvas #380: Expanded DiscourseContextOverlay to accept uid/id parameters; foundational change that enables the new rendering pattern introduced in ResultsTable.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "ENG-984 Add DiscourseContextOverlay support in ResultsTable" is specific and directly reflects the primary changes in the pull request. The changeset's main modifications are in ResultsTable.tsx, where DiscourseContextOverlay component rendering is introduced with action-aware logic, while the supporting change to predefinedSelections.ts adds the necessary constant. The title clearly identifies both the feature being added (DiscourseContextOverlay support) and the component where it's implemented (ResultsTable), making it easy for a developer scanning version history to understand the purpose of this PR.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e386761 and 3653c33.

📒 Files selected for processing (2)

• apps/roam/src/components/results-view/ResultsTable.tsx (3 hunks)
• apps/roam/src/utils/predefinedSelections.ts (2 hunks)

🔇 Additional comments (2)

apps/roam/src/utils/predefinedSelections.ts (1)

245-245: LGTM! Good use of a named constant.

Extracting the "overlay" string into a named constant improves maintainability and enables consistent usage across files.

Also applies to: 527-527

apps/roam/src/components/results-view/ResultsTable.tsx (1)

243-243: Good refactor: consistent use of extracted variable.

Using actionUid instead of re-accessing r[${key}-uid] improves code clarity and follows the DRY principle.