Skip to content

ENG-974 Sidebar crashing test branch #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

ENG-974 Sidebar crashing test branch #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d26d041
comment out drag-and-drop functionality to test bug
mdroidian Oct 19, 2025
50a13be
revert
mdroidian Oct 19, 2025
f4c1d0a
keepChildrenMounted
mdroidian Oct 19, 2025
7f96af3
minify false, sourcemap true
mdroidian Oct 19, 2025
ae6ecc1
.
mdroidian Oct 19, 2025
0785505
rm overflow-scroll
mdroidian Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/roam/scripts/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ export const compile = ({
"window.__DISCOURSE_GRAPH_VERSION__": `"${getVersion()}"`,
"window.__DISCOURSE_GRAPH_BUILD_DATE__": `"${getBuildDate()}"`,
},
sourcemap: process.env.NODE_ENV === "production" ? undefined : "inline",
minify: process.env.NODE_ENV === "production",
sourcemap: "inline",
minify: false,
entryNames: out,
external: externalModules.map(([e]) => e).concat(["crypto"]),
plugins: [
Expand Down
8 changes: 4 additions & 4 deletions apps/roam/src/components/LeftSidebarView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ const PersonalSectionItem = ({
)}
</div>
</div>
<Collapse isOpen={isOpen}>
<Collapse isOpen={isOpen} keepChildrenMounted>
<Droppable
droppableId={section.uid}
type="ITEMS"
Expand Down Expand Up @@ -429,7 +429,7 @@ const GlobalSection = ({ config }: { config: LeftSidebarConfig["global"] }) => {
</div>
</div>
{isCollapsable ? (
<Collapse isOpen={isOpen}>
<Collapse isOpen={isOpen} keepChildrenMounted>
<SectionChildren childrenNodes={config.children} />
</Collapse>
) : (
Expand Down Expand Up @@ -599,11 +599,11 @@ export const mountLeftSidebar = (
}
root = document.createElement("div");
root.id = id;
root.className = "starred-pages overflow-scroll";
root.className = "starred-pages";
root.onmousedown = (e) => e.stopPropagation();
wrapper.appendChild(root);
} else {
root.className = "starred-pages overflow-scroll";
root.className = "starred-pages";
}
ReactDOM.render(<LeftSidebarView onloadArgs={onloadArgs} />, root);
};
Expand Down
2 changes: 1 addition & 1 deletion apps/roam/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default runExtension(async (onloadArgs) => {
if (process.env.NODE_ENV === "development") {
renderToast({
id: "discourse-graph-loaded",
content: "Successfully loaded",
content: "Successfully loaded-no overflow-scroll on sidebar",
intent: "success",
timeout: 500,
});
Expand Down