Website: Refactor Blog Utils into General Utils #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
mdroidian
commented
Jan 8, 2025
| export async function getHtmlFromMarkdown(markdown: string): Promise<string> { | ||
| const htmlString = await unified() | ||
| .use(remarkParse) | ||
| .use(remarkHeadingId) |
Contributor
Author
There was a problem hiding this comment.
majority of the change in this function is for this remarkHeadingId.
I need to pass in the id to section headers for a table of contents and was having trouble finding a good way to do it. This refactor seems to satisfy for both (blog) and the upcoming (docs)
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bot goes boop? Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderrabbit Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
Author
|
@sid597 ready for review |
sid597
reviewed
Jan 9, 2025
sid597
reviewed
Jan 9, 2025
sid597
reviewed
Jan 9, 2025
Collaborator
|
lgtm, no blockers |
This was referenced Jan 9, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk of #52, will be using these in
/app/(docs)/roamSummary by CodeRabbit
New Features
Refactor
Chores