Skip to content

ENG-1536 Support multiple vault paths in Obsidian build script#891

Merged
trangdoan982 merged 7 commits intomainfrom
claude/loving-driscoll
Mar 23, 2026
Merged

ENG-1536 Support multiple vault paths in Obsidian build script#891
trangdoan982 merged 7 commits intomainfrom
claude/loving-driscoll

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented Mar 13, 2026 •
edited
Loading

https://www.loom.com/share/79291c06196e43bcae5544a7d2a3dd7c

Summary

  • Updates OBSIDIAN_PLUGIN_PATH to accept a comma-separated list of vault paths
  • Build output is now mirrored to all specified vaults on each rebuild
  • Updates .env.example with documentation on the multi-vault syntax

Test plan

  • Set OBSIDIAN_PLUGIN_PATH="vault1/path,vault2/path" in .env
  • Run turbo dev
  • Verify built files are copied to both vault paths
  • Verify single-path config still works as before
image here's how the "General" looks differently if i set the path to be single again

Closes ENG-1536

🤖 Generated with Claude Code

Open with Devin

@trangdoan982 @claude
ENG-1536 Support multiple vault paths in Obsidian build script
1f547ce 
Allow OBSIDIAN_PLUGIN_PATH to accept a comma-separated list of vault paths,
so devs can build once and mirror output to multiple vaults simultaneously.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@linear
Copy link
Copy Markdown

linear Bot commented Mar 13, 2026

ENG-1536 rewrite the build script so Obsidian build can output to more than 1 vault at a time

@supabase
Copy link
Copy Markdown

supabase Bot commented Mar 13, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@trangdoan982 trangdoan982 requested a review from mdroidian March 13, 2026 17:41
mdroidian
mdroidian requested changes Mar 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operating systems allow commas in file paths, so this approach would break.

We could use an array instead: OBSIDIAN_PLUGIN_PATH=["/path/a","/path/b"] and keep single-path support by treating non-JSON values as a single string

@trangdoan982
Copy link
Copy Markdown
Member Author

trangdoan982 commented Mar 16, 2026

@mdroidian made new changes to format with array instead. I tested with these scenarios and the script correctly made the changes to the right vault without affecting the other

  • array with multiple elements: OBSIDIAN_PLUGIN_PATH='["/Users/trang.doan/Documents/testVault/.obsidian/plugins/discourse-graphs","/Users/trang.doan/Documents/testVault2/.obsidian/plugins/discourse-graphs"]'
  • array with one vault: '["/Users/trang.doan/Documents/testVault/.obsidian/plugins/discourse-graphs"]'
  • no array, just string: OBSIDIAN_PLUGIN_PATH="/Users/trang.doan/Documents/testVault2/.obsidian/plugins/discourse-graphs"

@trangdoan982 trangdoan982 requested a review from mdroidian March 16, 2026 22:33
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

graphite-app[bot]

This comment was marked as resolved.

Sign in to view

trangdoan982 and others added 3 commits March 16, 2026 15:44
@trangdoan982 @devin-ai-integration
Update apps/obsidian/.env.example
25ba3a1 
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@trangdoan982 @graphite-app
Update apps/obsidian/scripts/compile.ts
180d4c8 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@trangdoan982
lint
37d5137
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

graphite-app[bot]

This comment was marked as resolved.

Sign in to view

trangdoan982 and others added 2 commits March 18, 2026 12:53
@trangdoan982
lint2
dfd7be0
@trangdoan982 @devin-ai-integration
Update apps/obsidian/scripts/compile.ts
91592de 
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
mdroidian
mdroidian approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove that additional line from .env.example before merging

Comment thread apps/obsidian/.env.example
# OBSIDIAN_PLUGIN_PATH="path/to/your/obsidian/vault/.obsidian/plugins/discourse-graph"
# For multiple vaults, use a JSON array:
# OBSIDIAN_PLUGIN_PATH='["/vault one/plugins/discourse-graph","/vault two/plugins/discourse-graph"]'
# OBSIDIAN_PLUGIN_REPO_TOKEN=your-github-pat-here No newline at end of file
Copy link
Copy Markdown
Member

@mdroidian mdroidian Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add OBSIDIAN_PLUGIN_REPO_TOKEN?

Copy link
Copy Markdown
Member Author

@trangdoan982 trangdoan982 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for the apps/obsidian/scripts/publish.ts script, so you can push a release to the discourse-graph-obsidian repo

Copy link
Copy Markdown
Member

@mdroidian mdroidian Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trangdoan982 Is this documented anywhere?

@trangdoan982 trangdoan982 merged commit 8cc8dc6 into main Mar 23, 2026
8 checks passed
@trangdoan982 trangdoan982 deleted the claude/loving-driscoll branch March 23, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdroidian mdroidian mdroidian approved these changes

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trangdoan982 @mdroidian