Skip to content

ENG-226: Fix dot-tag (.#sticky, .#meeting) flashing in query table results#904

Merged
sid597 merged 3 commits intomainfrom
eng-226-sticky-flashing-on-for-mouse-over-entire-query-table
Mar 22, 2026
Merged

ENG-226: Fix dot-tag (.#sticky, .#meeting) flashing in query table results#904
sid597 merged 3 commits intomainfrom
eng-226-sticky-flashing-on-for-mouse-over-entire-query-table

Conversation

@sid597
Copy link
Copy Markdown
Collaborator

@sid597 sid597 commented Mar 20, 2026

https://www.loom.com/share/57058df737784d07b543f1f34777b895


Open with Devin

Summary by CodeRabbit

  • Style
    • Query results view now hides unnecessary elements in result cells when not hovering, improving visual clarity.

sid597 added 2 commits March 20, 2026 10:37
Roam's dot-tags are hidden by default and shown via
`.rm-block__self:hover`. Since the entire query table is mounted
inside a single Roam block, hovering anywhere on the results
triggers all dot-tags to show. Scope visibility to the individual
cell wrapper instead.
Use td:not(:hover) instead of span-level selector so dot-tags
show when hovering anywhere in the cell, not just over the text.
@linear
Copy link
Copy Markdown

linear Bot commented Mar 20, 2026

@supabase
Copy link
Copy Markdown

supabase Bot commented Mar 20, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@sid597
Copy link
Copy Markdown
Collaborator Author

sid597 commented Mar 20, 2026

@coderabbitai full review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

Added a CSS rule to hide .rm-page-ref elements with tag attributes within .roamjs-query-results-view table cells when not hovered. Added trailing newline to the file.

Changes

Cohort / File(s) Summary
CSS Styling
apps/roam/src/styles/styles.css
Hide tag page-ref elements in query result table cells when not hovered using display: none !important override.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing dot-tag flashing in query table results, with concrete examples (.#sticky, .#meeting) and the issue context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

coderabbitai[bot]

This comment was marked as resolved.

@sid597 sid597 requested a review from mdroidian March 20, 2026 05:52
Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let's add a comment for future us that explains why this css is there, eg:

// Solves .#sticky flashing on for mouse over entire Query Table

@sid597 sid597 merged commit 59383dc into main Mar 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants