Skip to content

ENG-1664: Replace getBlockUidByTextOnPage scan with pull in settings writer #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 1 commit into from
Apr 24, 2026
Merged

ENG-1664: Replace getBlockUidByTextOnPage scan with pull in settings writer #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions apps/roam/src/components/settings/utils/accessors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import getBlockProps, {
} from "~/utils/getBlockProps";
import setBlockProps from "~/utils/setBlockProps";
import getBasicTreeByParentUid from "roamjs-components/queries/getBasicTreeByParentUid";
import getBlockUidByTextOnPage from "roamjs-components/queries/getBlockUidByTextOnPage";
import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTitle";
import { getSubTree } from "roamjs-components/util";
import getSettingValueFromTree from "roamjs-components/util/getSettingValueFromTree";
Expand Down Expand Up @@ -669,10 +668,17 @@ const setBlockPropBasedSettings = ({
return;
}

const blockUid = getBlockUidByTextOnPage({
text: keys[0],
title: DG_BLOCK_PROP_SETTINGS_PAGE_TITLE,
});
const pageResult = window.roamAlphaAPI.pull(
"[{:block/children [:block/uid :block/string]}]",
[":node/title", DG_BLOCK_PROP_SETTINGS_PAGE_TITLE],
) as Record<string, json> | null;
const children = (pageResult?.[":block/children"] ?? []) as Record<
string,
json
>[];
const match = children.find((child) => child[":block/string"] === keys[0]);
const matchedUid = match?.[":block/uid"];
const blockUid = typeof matchedUid === "string" ? matchedUid : "";

if (!blockUid) {
internalError({
Expand Down
Loading