Skip to content

ENG-1663: Error in create-block while changing the discourse node specification setting. #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 1 commit into from
Apr 24, 2026
+76 −64
Merged

ENG-1663: Error in create-block while changing the discourse node specification setting. #982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 76 additions & 64 deletions apps/roam/src/components/settings/DiscourseNodeSpecification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,72 +44,84 @@ const NodeSpecification = ({

React.useEffect(() => {
if (enabled) {
const scratchNode = getSubTree({ parentUid, key: "scratch" });
if (
!scratchNode.children.length ||
!getSubTree({ tree: scratchNode.children, key: "conditions" }).children
.length
) {
const conditionsUid = getSubTree({
parentUid: scratchNode.uid,
(async () => {
const scratchNode = getSubTree({
tree: getBasicTreeByParentUid(parentUid),
key: "scratch",
});
const conditionsNode = getSubTree({
tree: scratchNode.children,
key: "conditions",
}).uid;
const returnUid = getSubTree({
parentUid: scratchNode.uid,
key: "return",
}).uid;
createBlock({
parentUid: returnUid,
node: {
text: node.text,
},
})
.then(() =>
createBlock({
parentUid: conditionsUid,
node: {
text: "clause",
children: [
{ text: "source", children: [{ text: node.text }] },
{ text: "relation", children: [{ text: "has title" }] },
{
text: "target",
children: [
{
text: `/${
getDiscourseNodeFormatExpression(node.format).source
}/`,
},
],
},
],
},
}),
)
.then(() => {
setDiscourseNodeSetting(
node.type,
[DISCOURSE_NODE_KEYS.specification, SPECIFICATION_KEYS.query],
{
conditions: [
{
type: "clause" as const,
source: node.text,
relation: "has title",
target: `/${getDiscourseNodeFormatExpression(node.format).source}/`,
},
],
selections: [],
custom: "",
returnNode: node.text,
},
);
setMigrated(true);
});
if (!scratchNode.children.length || !conditionsNode.children.length) {
const scratchUid =
scratchNode.uid ||
(await createBlock({ parentUid, node: { text: "scratch" } }));
const conditionsUid =
conditionsNode.uid ||
(await createBlock({
parentUid: scratchUid,
node: { text: "conditions" },
}));
const returnUid =
getSubTree({ tree: scratchNode.children, key: "return" }).uid ||
(await createBlock({
parentUid: scratchUid,
node: { text: "return" },
}));
createBlock({
parentUid: returnUid,
node: {
text: node.text,
},
})
.catch((error) => {
internalError({ error });
});
}
.then(() =>
createBlock({
parentUid: conditionsUid,
node: {
text: "clause",
children: [
{ text: "source", children: [{ text: node.text }] },
{ text: "relation", children: [{ text: "has title" }] },
{
text: "target",
children: [
{
text: `/${
getDiscourseNodeFormatExpression(node.format).source
}/`,
},
],
},
],
},
}),
)
.then(() => {
setDiscourseNodeSetting(
node.type,
[DISCOURSE_NODE_KEYS.specification, SPECIFICATION_KEYS.query],
{
conditions: [
{
type: "clause" as const,
source: node.text,
relation: "has title",
target: `/${getDiscourseNodeFormatExpression(node.format).source}/`,
},
],
selections: [],
custom: "",
returnNode: node.text,
},
);
setMigrated(true);
})
.catch((error) => {
internalError({ error });
});
}
})().catch((error) => internalError({ error }));
} else {
const tree = getBasicTreeByParentUid(parentUid);
const scratchNode = getSubTree({ tree, key: "scratch" });
Expand Down
Loading