Ds2663 ds2648 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input character vector. * Fixed up documentation to be more consistent.
Travis CI needs to be able to download the CoreNLP java library and then run a unit test. * Updated travis.yml to allow for wget of CoreNLP, unzip it and set environment variable for CoreNLP * Added unit test of the Tom Cruise data. * Updated `cnlp_init_corenlp_custom` function to find CoreNLP if a system environment variable can point to it.
…wnloaded and environment var set.
…success or failure of entity unit tests
…it test calculation size for entity detection.
…onsolidate entity unit tests. Remove old code using the tab separated conll file approach that is unable to handle combined entities and uses custom regex commands to extract entities. Replaced with a entity extraction function that uses a json approach. Generated file is larger but handles entity combining automatically and no regex required to extract entities. General other housekeeping. * Change aut to ctb in DESCRIPTION * Update NAMESPACE for required jsonlite function * Remove multiarch R CMD check to stop rJava 32bit errors on local development machine * Move custom json entity extraction function NERAnnotate into separate R file.
…unction calls for other functions.
…unctions that trigger warnings.
…nt test warnings.
… and tweak travis code to remove Warnings. Output directory of CoreNLP English model jar files needed to be set correctly. Also ignoring vignettes in the R check since vignettes output is cleared on each package build and travis cant see the output.
… after download and build check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira DS-2663