You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exit right away if the engine isn’t found.
This makes the error message clearer by saying the executable doesn’t exist, rather than showing the previous generic one: "Fatal; <engine_name> engine startup failure: Couldn't start engine process."
This has multiple flaws
a) the filesystem usage is currently not guarded
b) this assume cmd is an exact path which
might not be the case when used together with dir
c) we had this in the past but removed it because we allowed engines to be started from PATH which means filesystem checks will fail unless the path is expanded which I don't want to do
I think all three issues you mentioned can be addressed:
a) guard the std::filesystem logic
b) check if dir is defined, and concatenate with cmd before checking (maybe with an helper function and call it at the end of parseEngine and parseEach or in sanitize as it was done before #869?)
c) only run the check if we have an absolute path or dir is set
yeah so for
a) you'd have to use NO_STD_FILESYSTEM, which currently also used in other places
b) that logic should go in sanitize
c) we can check if it is an absolute path, im not sure how you do the check when dir is set since you might have to check the path..
Pushed a new commit with the following fixes:
a) guards for filesystem
b) added dir handling and move the logic to sanitize
c) check if using absolute path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit right away if the engine isn’t found.
This makes the error message clearer by saying the executable doesn’t exist, rather than showing the previous generic one: "Fatal; <engine_name> engine startup failure: Couldn't start engine process."