fix: update engine pointers when engine crashes#915
fix: update engine pointers when engine crashes#915Disservin merged 1 commit intoDisservin:masterfrom
Conversation
|
Thanks, I wonder if we could have a unit test for this case and your other PR. I'm currently traveling so can't write one right now but will try to when I'm back unless someone already opens a pr in the meantime |
|
Hm I don't know much about the unit test of fastchess at the moment. But testing something like my other PR is probably not suitable, because it needs
I believe unit tests are not supposed to test such things. Simulating engine stall/disconnections might be feasible, but again I'm not familiar with this thing now... |
|
Yeah I can do it, there are already tests not really unit though, which use a random mover engine or a simple dummy one. Regarding file descriptors valgrind has an option to track them which I think is already done in one test, I think the same logic can be reused there |
Fixes #908