Skip to content

Conversation

@ProgrammedByHussain
Copy link
Contributor

A few changes in configs and imports

@fhackett
Copy link
Collaborator

The change in principle looks fine, but it failed the formatting.

Inspired by this, I pushed proper documentation and automation for running all the auto-formatters before push.

Can you have a try?

@fhackett
Copy link
Collaborator

Actually, I just realized that DAP is enabled in the code you pushed, so all the CI runners are waiting for the debugger to connect now.

Can you comment that out for now?

I am becoming more convinced that that API should actually be an env variable, so we can add it to our command-lines but CI will never have to deal with it (accidentally at least).

@fhackett
Copy link
Collaborator

Cool, thanks. Can you also merge with main and run ./rewrite_src.sh (or read the updated README w/ more details)?

The CI format checks are still failing, and that script will just make it go away 99% of the time.

@fhackett fhackett merged commit a5c33fc into DistCompiler:main May 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants