feat: category-specific import menus & DAT parser independent feature flags

[BrewertonSantos]

Summary

Two features for the Assets & Map Editor:

1. Category-specific import menus

Split the single "Merge Session Into Current…" menu into 4 separate menus:

• Import Items (cube icon)
• Import Outfits (shirt icon)
• Import Effects (wand icon)
• Import Missiles (arrow icon)

Each menu dynamically lists available session DAT files and imports only the selected category.

2. DAT parser: independent feature flags

The DAT parser previously derived extended (U32 sprites), enhancedAnimations, and frameGroups from the protocol version number. This failed for custom DAT files (e.g. PStory) that use hybrid combinations — V4 flags (proto 854) + U32 sprites + enhanced animations + frame groups — a mix no standard Tibia version uses.

Root cause: PStory client treats these as independent feature flags and tries multiple combinations via tryLoadDatWithFallbacks. Our parser now does the same.

Before: Items=39100, Outfits=4970/5030, Effects=0/2208, Missiles=0/223
After: Items=39100, Outfits=5030/5030, Effects=2208/2208, Missiles=223/223

Changes

• DatFile.cs: ParseThing accepts separate bool extended, bool enhancedAnimations, bool frameGroups; Load() tries 8 feature combos per protocol; Save/WriteThing respects flags
• DatData: Added EnhancedAnimations and FrameGroups properties
• MainWindow.axaml: 4 category-specific import MenuItems
• MainWindow.axaml.cs: WireImportMenu() helper
• MainWindowViewModel.cs: MergeSessionAsync accepts ThingCategory? filter

[Copilot]

Pull request overview

Adds category-scoped session importing in the Assets & Map Editor UI and updates the DAT parser to treat extended, enhancedAnimations, and frameGroups as independent feature flags (with fallback attempts across combinations) to better support hybrid/custom DAT formats.

Changes:

• Split “Merge Session Into Current…” into four per-category import menus (Items/Outfits/Effects/Missiles) that import only the selected category.
• Updated DAT parsing to try multiple independent feature-flag combinations per protocol and preserve best partial parses when perfect parsing is not possible.
• Updated DAT writing to respect extended (U16 vs U32 sprite indices) and the independent animation/frame-group flags.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
src/OTB/DatFile.cs	Implements independent feature-flag parsing fallbacks; propagates flags into DatData; updates DAT writing for sprite index size and optional enhanced animation/frame-groups.
src/App/ViewModels/MainWindowViewModel.cs	Adds optional category filter to MergeSessionAsync and exposes a category→dictionary selector used by import menus.
src/App/MainWindow.axaml.cs	Wires four dynamic import submenus that call the category-filtered import path.
src/App/MainWindow.axaml	Replaces the single merge menu entry with four category-specific import menu items and icons.

Comments suppressed due to low confidence (1)

src/App/ViewModels/MainWindowViewModel.cs:5209

• Making GetCategoryDict public exposes the mutable backing dictionaries for DatData to any caller, which makes it easy for UI/code-behind to mutate session state unintentionally. If you only need counts for the import menu, consider keeping this private/internal and adding a small helper that returns the count (or returning an IReadOnlyDictionary) instead of the mutable Dictionary.

    public static Dictionary<ushort, DatThingType> GetCategoryDict(DatData data, ThingCategory category)
    {
        return category switch
        {
            ThingCategory.Outfit => data.Outfits,
            ThingCategory.Effect => data.Effects,
            ThingCategory.Missile => data.Missiles,
            _ => data.Items,
        };

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This Click handler is async and its exceptions will go unhandled (event handlers are effectively async void). Wrap the awaited call in a try/catch and route errors into StatusText/logging to avoid crashes if MergeSessionAsync throws.

Suggested change

	mi.Click += async (_, _) => await vm.MergeSessionAsync(source, category);
	mi.Click += async (_, _) =>
	{
	try
	{
	await vm.MergeSessionAsync(source, category);
	}
	catch (Exception ex)
	{
	Console.Error.WriteLine($"Error merging session '{source.Name}' for category '{category}': {ex}");
	}
	};

[Copilot]

StatusText pluralization is always "{label}s" which produces grammatically incorrect text for singular (e.g., "Analyzing 1 source items"). Consider using a simple singular/plural branch based on totalSource to keep status messages correct.

Suggested change

	StatusText = $"Analyzing {totalSource} source {label}s for duplicates…";
	var labelText = totalSource == 1 ? label : label + "s";
	StatusText = $"Analyzing {totalSource} source {labelText} for duplicates…";

[Copilot]

The final failure message still says "No protocol/extended combination worked" but loading now varies multiple independent feature flags (extended/enhancedAnimations/frameGroups). Update the message to reflect that all protocol/feature-flag combinations were attempted so logs/errors are accurate.

Suggested change

	$"Failed to parse {Path.GetFileName(path)} (sig=0x{sig:X8}, size={raw.Length}). No protocol/extended combination worked.");
	$"Failed to parse {Path.GetFileName(path)} (sig=0x{sig:X8}, size={raw.Length}). No protocol/feature-flag combination (extended/enhancedAnimations/frameGroups) worked.");

[Copilot]

When frameGroups is disabled, this method still iterates over thing.FrameGroups.Length but does not write the group count/type fields. If thing.FrameGroups has more than 1 entry, the saved DAT will be malformed. Consider writing only the first frame group (or throwing/normalizing) when frameGroups == false, and similarly validate that FrameGroups is non-empty when frameGroups == true.

Suggested change

	if (isOutfit && frameGroups)
	w.U8((byte)thing.FrameGroups.Length);
	for (int g = 0; g < thing.FrameGroups.Length; g++)
	int groupCount = thing.FrameGroups != null ? thing.FrameGroups.Length : 0;
	if (isOutfit && frameGroups)
	{
	if (groupCount == 0)
	throw new System.InvalidOperationException("Outfit thing with frameGroups enabled must have at least one FrameGroup.");
	w.U8((byte)groupCount);
	}
	int groupsToWrite = frameGroups ? groupCount : Math.Min(groupCount, 1);
	for (int g = 0; g < groupsToWrite; g++)

[Copilot]

When extended == false, sprite IDs are written as U16 by casting from uint. If any sprite ID exceeds ushort.MaxValue, this will silently truncate and corrupt the DAT. Add an explicit range check (and fail fast / clamp) when writing legacy (non-extended) DATs.

Suggested change

	if (extended) w.U32(sid); else w.U16((ushort)sid);
	if (extended)
	{
	w.U32(sid);
	}
	else
	{
	if (sid > ushort.MaxValue)
	{
	throw new System.InvalidOperationException(
	$"Sprite ID {sid} exceeds maximum value {ushort.MaxValue} for non-extended DAT.");
	}
	w.U16((ushort)sid);
	}

[Copilot]

DatReader.Seek sets _pos directly without any bounds/negative validation. A negative position can bypass EnsureAvailable checks (e.g., _pos + bytes > data.Length) and cause undefined reads. Add validation to keep position within [0, data.Length] (or throw) to keep the reader safe if Seek is used later.