Updating vesting registry and creating cron job to extend staking#428
Merged
smbsp merged 9 commits intoupgradable-vestingfrom Apr 26, 2022
Merged
Updating vesting registry and creating cron job to extend staking#428smbsp merged 9 commits intoupgradable-vestingfrom
smbsp merged 9 commits intoupgradable-vestingfrom
Conversation
smbsp
requested review from
Alitasovryn,
jameshowlett977,
ororopickpocket and
tjcloa
tjcloa
reviewed
Apr 21, 2022
Comment on lines
+109
to
+111
| uint256 vestingCreationType = 4; | ||
| uint256 cliff = 4 weeks; | ||
| uint256 duration = 156 weeks; |
Contributor
There was a problem hiding this comment.
VR4 - vars can be constants
tjcloa
reviewed
Apr 21, 2022
| uint256 cliff = 4 weeks; | ||
| uint256 duration = 156 weeks; | ||
| for (uint256 i = 0; i < _tokenOwners.length; i++) { | ||
| require(_tokenOwners[i] != address(0), "token owner cannot be 0 address"); |
Contributor
There was a problem hiding this comment.
CD19 - require enumeration throughout all the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.