Fix/staking extend staking duration#477
Merged
jameshowlett977 merged 12 commits intorefactoring/staking-contract-eip170from Jan 25, 2023
Merged
Fix/staking extend staking duration#477jameshowlett977 merged 12 commits intorefactoring/staking-contract-eip170from
jameshowlett977 merged 12 commits intorefactoring/staking-contract-eip170from
Conversation
…xtendStakingDuration # Conflicts: # tests/staking/StakingTest.js
cwsnt
reviewed
Jan 24, 2023
| }); | ||
|
|
||
| describe("extendStakingDuration", () => { | ||
| // it("should fail if second stake in the same block", async () => { |
Contributor
There was a problem hiding this comment.
LGTM, but are we good to remove this test case?
Contributor
Author
There was a problem hiding this comment.
Sorry, haven't pushed last commit with uncommented test.
cwsnt
reviewed
Jan 24, 2023
| whenNotPaused | ||
| whenNotFrozen | ||
| { | ||
| previousLock = _timestampToLockDate(previousLock); |
Contributor
There was a problem hiding this comment.
This function will revert if user input 0 value for the previousLock?
Contributor
Author
There was a problem hiding this comment.
Yes, it will fail, added test to check.
cwsnt
approved these changes
Jan 25, 2023
ororopickpocket
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.