Skip to content

Implement new PG HTML <title> field format#15

Merged
cpeel merged 2 commits intoDistributedProofreaders:masterfrom
rtonsing:master
Jan 15, 2023
Merged

Implement new PG HTML <title> field format#15
cpeel merged 2 commits intoDistributedProofreaders:masterfrom
rtonsing:master

Conversation

@rtonsing
Copy link
Copy Markdown
Collaborator

To test, remove title or leave out "Gutenberg".

Copy link
Copy Markdown

@windymilla windymilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should do a slightly stronger check as the current code would allow through the old format.
Maybe at line 750, something like
if not t3.endswith(" | Project Gutenberg"):
You also wouldn't need the check below for the title ending with a full stop.

@windymilla
Copy link
Copy Markdown

@cpeel Making this live at ppwb should probably be done after (not before) forum/news announcements of the change by Linda or people will get the warning and not know why

@rtonsing
Copy link
Copy Markdown
Collaborator Author

Could we push this to the test site to try out? And the previous version to PROD?

Copy link
Copy Markdown

@windymilla windymilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@cpeel
Copy link
Copy Markdown
Member

cpeel commented Jan 15, 2023

TEST and PROD are now running the latest ppwb, ppcomp, pphtml, and pptext. After this gets merged in I'm happy to push it out to TEST.

@cpeel cpeel merged commit 692c684 into DistributedProofreaders:master Jan 15, 2023
@cpeel
Copy link
Copy Markdown
Member

cpeel commented Jan 15, 2023

TEST is now running the code from this PR.

@windymilla
Copy link
Copy Markdown

Behavior appears correct on TEST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants