test(js): add tests for boolean values between JS & PY #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesgarland
requested changes
Jul 16, 2023
Collaborator
wesgarland
left a comment
wesgarland
left a comment
There was a problem hiding this comment.
Other than the email address, LGTM, let's fix that so I can merge asap
tests/js/js2py/boolean.simple
Outdated
| * booleans to Python and getting them back into JS as primitive | ||
| * booleans retains the correponsing logical values. | ||
| * | ||
| * @author Bryan Hoang <bryan@ditributive.network> |
Collaborator
There was a problem hiding this comment.
your e-mail address is bryan@distributive.network 🥇 🤣
Contributor
Author
There was a problem hiding this comment.
Whoops! I've added the missing 's'.
Boxed boolean values are tested in addition to primitive boolean values to make sure that both the literal and the `typeof` values make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxed boolean values were tested in addition to primitive boolean values
to make sure that both the literal and the
typeofvalues made sense.