Add tests for passing Objects between JS <=> Python #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject methods performed on it
can be modified Co-authored-by: Will Pringle <willkantorpringle+1@gmail.com>
Xmader
requested changes
Aug 2, 2023
Member
`==` only compares if the two JS objects have the same memory address.
Member
|
It's stupid that GitHub automatically closes this pull request when the |
Member
|
Once this merge target is changed to |
Xmader
reviewed
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for passing Objects between JS and Python, and some trivial operations on them.
Couple of issues I've found:
Object.values()andObject.entries()on a JS Object created from Python causes a segfault (Segfault when using Object.values() and Object.entries() #117)