Skip to content

fix(build.py): git submodule update fails when installing from source distribution (sdist) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hamada-Distributed merged 2 commits into from
Sep 1, 2023
Merged

fix(build.py): git submodule update fails when installing from source distribution (sdist) #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b98812
fix(build.py): `git submodule update` fails when installing by sdist
Xmader Aug 17, 2023
ff4c7d1
fix(build.py): move submodule checkout to the commonjs testing script
Xmader Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def copy_artifacts():
execute("cp ./_spidermonkey_install/lib/libmozjs* ./python/pythonmonkey/", cwd=TOP_DIR)

def build():
execute("git submodule update --init --recursive", cwd=TOP_DIR)
ensure_spidermonkey()
run_cmake_build()
copy_artifacts()
Expand Down
6 changes: 5 additions & 1 deletion tests/js/commonjs-modules.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ panic()
echo "$*" >&2
exit 2
}
cd `dirname "$0"`/../commonjs-official/tests/modules/1.0 || panic "could not change to test directory"

cd `dirname "$0"`
git submodule update --init --recursive || panic "could not checkout the required git submodule"

cd ../commonjs-official/tests/modules/1.0 || panic "could not change to test directory"

runTest()
{
Expand Down