Implement setInterval functions & Fix timers memory bug
#311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` timers could be run When a `std::vector` gets expanded, reallocation happens, and the memory block is moved to somewhere else. We could no longer use a pointer to the handle after reallocation, but no problem if we use indices (i.e. the `timeoutId`).
…ss the job function succeeds or not
…tInterval` callback
Xmader
force-pushed
the
Xmader/feat/timers-setInterval
branch
from
f625c0b to
962ff2d
Compare
…mented `Timeout.refresh()` method
…require the event-loop
fix English Co-authored-by: philippedistributive <151072087+philippedistributive@users.noreply.github.com>
Co-authored-by: philippedistributive <151072087+philippedistributive@users.noreply.github.com>
…tivated again when a finished timer gets re-refed.
philippedistributive
previously approved these changes
Apr 11, 2024
zollqir
requested changes
Apr 11, 2024
Collaborator
zollqir
left a comment
zollqir
left a comment
There was a problem hiding this comment.
LGTM apart from one missing decref
A new reference to `jobFn` is created in `enqueueWithDelay` by `PyCFunction_New`, so we are safe to decrease the reference count here. Co-authored-by: Caleb Aikens <caleb@distributive.network>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
setInterval/clearIntervalglobal functionsSee MDN and the spec
Fix a memory bug that limits the number of
setTimeout/setIntervaltimers could be runFix
pmjs -e/pmjs -pnot being able to call functions that require the event-loopCloses #266