Add a globally-available pm.require that gets the caller’s filename from the Python call stack
#60
Conversation
…require for the same filename
…e function itself
| def require(moduleIdentifier: str): | ||
| # Retrieve the caller’s filename from the call stack | ||
| filename = inspect.stack()[1].filename | ||
| return createRequire(filename)(moduleIdentifier) |
There was a problem hiding this comment.
This has the side effect of creating a new, unique, require function for the current module each time it is invoked, because createRequire instantiates the CtxModule constructor, creating a new "module" for the require to live in. That will also cause us to subtly violate the CommonJS principle that each module is a singleton.
I think we avoid all of the possible subtle gotchas and possibly perform a little faster if we cache the return value of createRequire in a dict or something, always using the same require for the same filename.
This will be especially important once we support require.cache, require.path, etc, from Python.
In the future, the best way to do that cache lookup might be to look at require.cache, but PythonMonkey does not currently support function properties, so we can't do that today.
The stack filename is `<stdin>` for the REPL, which is not a valid path
No description provided.