Skip to content

Fix: Python modules require can't see exports['abc'] = xyz #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xmader merged 1 commit into from
Jul 5, 2023
Merged

Fix: Python modules require can't see exports['abc'] = xyz #67

Xmader merged 1 commit into from
Jul 5, 2023

Conversation

@Xmader
Copy link
Member

@Xmader Xmader commented Jul 5, 2023 •
edited
Loading

python.load should use the module.exports dict instead of taking the Pythonic exports

@Xmader Xmader changed the title Fix: requiring Python modules can't see exports['abc'] = xyz Fix: Python modules require can't see exports['abc'] = xyz Jul 5, 2023
@Xmader Xmader mentioned this pull request Jul 5, 2023
Closed
@Xmader Xmader merged commit b198aff into main Jul 5, 2023
@Xmader Xmader deleted the Xmader/fix/require-python-module branch July 5, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hamada-Distributed Hamada-Distributed Hamada-Distributed approved these changes

@wesgarland wesgarland Awaiting requested review from wesgarland

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xmader @Hamada-Distributed