Skip to content

pmjs improved parsing #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xmader merged 14 commits into from
Jul 17, 2023
Merged

pmjs improved parsing #83

Xmader merged 14 commits into from
Jul 17, 2023

Conversation

@wesgarland
Copy link
Collaborator

@wesgarland wesgarland commented Jul 11, 2023

This fixes

  • problems displaying object literals in the repl (now same as node)
  • problems using boolean options in pm.eval
  • segfault when pm.eval is called with no arguments

@wesgarland wesgarland changed the base branch from main to wes/improved-pmjs July 11, 2023 03:09
@wesgarland
Copy link
Collaborator Author

wesgarland commented Jul 11, 2023

I've set the base branch to wes/improved-pmjs (PR73?) to keep the review surface small.

Base automatically changed from wes/improved-pmjs to main July 11, 2023 20:48
@Xmader Xmader changed the base branch from main to wes/pmjs-use-inspect July 11, 2023 20:57
@Xmader Xmader self-requested a review July 12, 2023 15:18
Base automatically changed from wes/pmjs-use-inspect to main July 14, 2023 02:49
Xmader
Xmader reviewed Jul 14, 2023
View reviewed changes
Xmader
Xmader reviewed Jul 14, 2023
View reviewed changes
Xmader
Xmader reviewed Jul 14, 2023
View reviewed changes
Xmader
Xmader reviewed Jul 14, 2023
View reviewed changes
Xmader
Xmader requested changes Jul 14, 2023
View reviewed changes
@wesgarland wesgarland requested a review from Xmader July 15, 2023 20:03
@wesgarland wesgarland mentioned this pull request Jul 16, 2023
Closed
@wesgarland wesgarland added this to the v0.2.0 milestone Jul 16, 2023
Xmader
Xmader approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@Xmader Xmader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xmader Xmader merged commit 190a1a2 into main Jul 17, 2023
@Xmader Xmader deleted the wes/pmjs-improved-parsing branch July 17, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xmader Xmader Xmader approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wesgarland @Xmader