Better setTimeout APIs
#86
Conversation
…the callback function
Xmader
force-pushed
the
Xmader/feat/better-setTimeout
branch
from
6dc3d4c to
0f990f1
Compare
|
What is preventing this branch from landing? Just review from @caleb-distributive ? |
|
It's missing |
To make this pull request land sooner, I decided to split it into separate PRs. |
Xmader
force-pushed
the
Xmader/feat/better-setTimeout
branch
from
c6bf140 to
4b5cfab
Compare
|
|
||
| // Schedule job to the running Python event-loop | ||
| PyEventLoop loop = PyEventLoop::getRunningLoop(); | ||
| if (!loop.initialized()) return false; |
There was a problem hiding this comment.
Should we set an exception here?
There was a problem hiding this comment.
No.
We've had already thrown an exception inside PyEventLoop::getRunningLoop()
https://github.com/Distributive-Network/PythonMonkey/blob/4da2838/src/PyEventLoop.cc#L76-L77
wesgarland
left a comment
wesgarland
left a comment
There was a problem hiding this comment.
Nice work - can't wait to see this land
| 'vars-on-top': [ 'error' ], | ||
| 'no-var': [ 'off' ], | ||
| 'spaced-comment': [ 'warn' ], | ||
| 'brace-style': [ 'off' ], |
There was a problem hiding this comment.
note that this will generate false positives on code which acceptable per DCP JS coding style. Not really a big deal unless you want to never have spurious warnings. One of the core team members apparently made an es-lint plug-in that understands this, but I haven't reviewed it.
DCP bracing style is
- allman style for flow control and function declaration
- k&r style for object and function literals
- literal braces always followed by ; or ,
- top-level assignment to function literal in allman style, eg. module exports property assignments
This is a good style for reading but a hard style for linting.
setTimeout/clearTimeoutin JS with C++ internal bindings, cleaner codecodestring tosetTimeoutas the callback functionsetInterval/clearIntervalqueueMicrotask