Add filter_add so all filter sender are created at startup#1452
Merged
Conversation
8 tasks
Closed
2 tasks
Collaborator
|
It solve the problem for the Audio Filter. BUT the audio is "always running" as well (aka not dependent on the parent / source being active/showing or not.) |
Collaborator
|
Tested and confirmed to work on both audio & video filter. |
Trouffman
changed the title
Collaborator
|
This will be merged. Acknowledging the research work by @paulpv here :) |
Trouffman
approved these changes
Apr 23, 2026
Collaborator
Trouffman
left a comment
Trouffman
left a comment
There was a problem hiding this comment.
Tested and address the issue it fixes.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix (#1449).
The regression was caused by "Default NDI name for filters to be
<filter> (<source>)" (#1412)Instead of checking to see if the sender needs creating in the filter_tick (which is not called on an audio only filter) we now do that check in the new ndi_filter_add function.
A side note on implementation: copilot suggested numerous changes to fix this, one of them being to add a filter_add callback. The other changes suggested by copilot were to supposedly fix a race condition which could not be duplicated so those suggested changes were not included in this PR.
This is a regression and should be included in a hot fix in 6.2.1