fix(tracing): buffer bridge events to eliminate ghost traces#116
Merged
fix(tracing): buffer bridge events to eliminate ghost traces#116
Conversation
…116) Root cause: Runtime.addBinding is async — on page navigation, the bridge script (via addScriptToEvaluateOnNewDocument) fires BEFORE Chrome registers __rrwebPush in the new execution context. For fast-solving managed Turnstile widgets (Ahrefs), the token is available within ms of page load. emit() silently dropped the event, tokenReported=true prevented retries, and awaitResolutionRace waited the full 60s timeout for a signal that was permanently lost. Fix: Buffer events in emit() and flush via 50ms poll when the binding appears. Also includes trace improvements from production analysis: - Add click timing attributes to cf.resolutionRace span - Fix empty cf.domain for malformed URLs - Update tab.url span attribute on navigation - Add screencast.fps/duration_s attributes - Add solved_set_size warning log (>50) - Add BridgeEvent timing type to union - Add vitest JSON reporter for test output capture
DivMode
added a commit
that referenced
this pull request
Mar 12, 2026
Managed/invisible Turnstile widgets (e.g. Ahrefs) auto-solve after 30-60s but the fast 20ms hook poll stops once hooks are installed. The render() callback handles most cases, but managed widgets can solve after the fast poll exits — leaving only auto_navigation (page navigates) to resolve, causing 50-60s ghost traces in cf.resolutionRace. Add a 1s getResponse() fallback poll (90s lifetime) that catches tokens from widgets solved after the fast poll stops. This should eliminate the remaining ghost traces not fixed by PR #116's bridge event buffering.
4 tasks
DivMode
added a commit
that referenced
this pull request
Mar 12, 2026
…117) Managed/invisible Turnstile widgets (e.g. Ahrefs) auto-solve after 30-60s but the fast 20ms hook poll stops once hooks are installed. The render() callback handles most cases, but managed widgets can solve after the fast poll exits — leaving only auto_navigation (page navigates) to resolve, causing 50-60s ghost traces in cf.resolutionRace. Add a 1s getResponse() fallback poll (90s lifetime) that catches tokens from widgets solved after the fast poll stops. This should eliminate the remaining ghost traces not fixed by PR #116's bridge event buffering.
DivMode
added a commit
that referenced
this pull request
Mar 12, 2026
…ests (#118) * fix(cf): add slow fallback token poll for managed/invisible widgets Managed/invisible Turnstile widgets (e.g. Ahrefs) auto-solve after 30-60s but the fast 20ms hook poll stops once hooks are installed. The render() callback handles most cases, but managed widgets can solve after the fast poll exits — leaving only auto_navigation (page navigates) to resolve, causing 50-60s ghost traces in cf.resolutionRace. Add a 1s getResponse() fallback poll (90s lifetime) that catches tokens from widgets solved after the fast poll stops. This should eliminate the remaining ghost traces not fixed by PR #116's bridge event buffering. * fix(cf): reload page when Turnstile widget fails to render + speed up integration tests When solver returns NoClick (OOPIF exists but no checkbox renders), wait a grace period for bridge auto-solve, then reload the page to give CF a fresh chance. Prevents 60s dead waits on stuck widgets. Integration test speedups: reduce post-solve buffer 3s→1s, replace fixed replay flush sleeps with polling, fix checkbox timing assertion to isolate sleep interval from CDP call latency. * fix(test): add 10-minute cooldown to cf-stress to prevent IP burn on back-to-back runs cf-stress runs 15 concurrent tabs through Ahrefs CF challenges. The proxy IP gets rate-limited after ~30 CF solves. When vitest runs explicitly then again via pre-push hook, cf-stress always fails on the second run because the IP is burned. Cooldown file /tmp/cf-stress-last-pass tracks last pass time — skips if <10 minutes elapsed. * fix(test): widen solver integration test timeout to 60s The solve session test had { timeout: 20_000 } which was too tight — goto + CF solve + replay flush + assertions can take 15-25s depending on network and CF timing. The config timeout was already widened to 60s but this per-test override was missed. * fix(test): increase solver test marker buffer to 3s for auto-solve race When CF serves a non-interactive Turnstile variant, turnstile.getResponse() returns a token in ~1s but the server-side solver is still in phase 3 checkbox polling. The 500ms buffer was too short — browser.close() killed the session before the bridge push could arrive, causing cf.failed with session_close. 3s gives the bridge push time to propagate. * fix(test): increase interstitial wait to 20s — CF can take 10-15s to verify CF interstitials (managed challenges) can take 10-15s to verify and redirect, especially under proxy load. The 8s waitForNavigation timeout was too tight — CF slow-walks verification on rate-limited IPs. 20s gives ample time while staying well under the 60s per-test timeout. * fix(test): make 2captcha-cf maySkip + tolerate session_close on skip sites 2captcha.com demo has its own rate limits on top of CF. Under proxy load, CF's interstitial challenge refuses to resolve (15s+ "Just a moment..." with no navigation). Extended maySkip to also skip gracefully when the challenge is served but never resolves (session_close label).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime.addBindingis async — on page navigation, the bridge script fires BEFORE Chrome registers__rrwebPushin the new execution context. For fast-solving managed Turnstile widgets (Ahrefs), the token is available within milliseconds.emit()silently dropped the event,tokenReported=trueprevented retries, andawaitResolutionRacewaited the full 60s timeout for a signal permanently lost.emit()and flush via 50ms poll when the binding appears. Eliminates 50-60s ghostcf.resolutionRacespans that inflated tab root spans to 1-1.5 minutes.Test plan
npx tsc --noEmitpassesbridge_solvedfires correctly on all embedded turnstile typespeet-nonint,peet-invisible,peet-managedall resolve viabridge_solvedsignalcf.resolutionRace>30s)