refactor: remove Logger SDK interface and delete logger.ts#122
Merged
Conversation
Remove the Logger class (debug npm module wrapper) from the entire SDK interface. All ~75 remaining logger.*() calls in route handlers and browser classes migrated to Effect structured logging. Logger parameter removed from all 4 abstract handler signatures in types.ts, cascading through 28+ route and infrastructure files. - Delete src/logger.ts (151 lines) - Remove Logger from handler signatures (HTTPRoute, BrowserHTTPRoute, WebSocketRoute, BrowserWebsocketRoute) - Remove per-request Logger instantiation from router.ts and server.ts - Remove Logger from container/bootstrap service registration - Migrate browsers.cdp.ts (28 calls) and browsers.playwright.ts (8 calls) - Migrate 10 shared route handler files to Effect logging - Keep debug npm dependency (still used by config.ts, sdk-utils.ts, utils.ts) Completes Phase 8B — zero Logger references remain in production code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/logger.ts(151 lines) — thedebugnpm module wrapperLoggerparameter from all 4 abstract handler signatures intypes.tsbrowsers.cdp.ts(28 calls) andbrowsers.playwright.ts(8 calls) to Effect loggingdebugnpm dep (still used by config.ts, sdk-utils.ts, utils.ts)32 files changed, -361 lines. Zero Logger references remain in production code.
Test plan
npx tsc --noEmit— typechecknpx vitest run— all tests pass